Consistent Camera/Adjusted UI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the camera consistently work and adjusted the UI for after you take a photo so it flows better.
|
Hmm, no worky. My iphone 8 screen:
|
|
Still consistently, no way to get any controls on the screen, no audio snap, no way to take a picture from what I can see. Screen tap does seem to do something, but not sure what. |
|
@AdAstraCA you might want to also post your screenshots to help with verification. |
|
The Xcode testing for different iPhone types doesn't compile on the Mac for
me. I'll try to compile different layouts, though.
…On Tue, Feb 7, 2023 at 1:04 AM David J. Kordsmeier ***@***.***> wrote:
Hmm, no worky.
My iphone 8 screen:
[image: IMG_0071]
<https://user-images.githubusercontent.com/64202/217199846-e6142fba-4e64-4529-8e06-fc7eba03535f.PNG>
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCLH2OW5VPIPE4Z4EQQDB3WWIF3JANCNFSM6AAAAAAUOUMCEA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Here is proof that it works on my end. It probably doesn't work on your end
because of the different phone layout, which I am having trouble testing
properly. However, I'll try and figure that out(tho not prioritized because
of the emulator work).
…On Tue, Feb 7, 2023 at 1:06 AM David J. Kordsmeier ***@***.***> wrote:
@AdAstraCA <https://github.com/AdAstraCA> you might want to also post
your screenshots to help with verification.
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCLH2LYJ33FUU6CVMXKKFLWWIGBTANCNFSM6AAAAAAUOUMCEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the camera consistently work and adjusted the UI for after you take a photo so it flows better(#15 #23 #20 #21)